Skip to content

Fix BodyId link typo in glossary #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2020

Conversation

Nashenas88
Copy link
Contributor

No description provided.

@Nashenas88 Nashenas88 requested a review from mark-i-m May 23, 2020 16:39
Copy link
Member

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@chrissimpkins
Copy link
Member

Hmmm... CI failing on something unrelated to your changes here Paul.

https://travis-ci.com/github/rust-lang/rustc-dev-guide/builds/167907317#L338

@mark-i-m OK to merge with this fail?

@Nashenas88
Copy link
Contributor Author

@chrissimpkins I fixed the broken link in this case as well. Seems the enum was split into an enum kind and a wrapping struct. I pointed to the struct for now since it seems to be the main point of use.

@LeSeulArtichaut
Copy link
Contributor

I opened #711 to fix the broken link (I didn't see it was fixed here).

@LeSeulArtichaut
Copy link
Contributor

@mark-i-m OK to merge with this fail?

Btw @chrissimpkins I think we can't merge when CI fails because it is marked as "required".

@Nashenas88 Nashenas88 merged commit 59c9fa7 into rust-lang:master May 23, 2020
@Nashenas88 Nashenas88 deleted the body_id_glossary_typo branch May 23, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants